Skip to content

Use Turbo Frame for picture dialog for#2950

Merged
tvdeyen merged 1 commit intomainfrom
turbo-frame-picture-dialog
Jul 1, 2024
Merged

Use Turbo Frame for picture dialog for#2950
tvdeyen merged 1 commit intomainfrom
turbo-frame-picture-dialog

Conversation

@tvdeyen
Copy link
Copy Markdown
Member

@tvdeyen tvdeyen commented Jul 1, 2024

What is this pull request for?

Get rid of another update.js.erb template

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

Get rid of another js.erb template
@tvdeyen tvdeyen added this to the 7.3 milestone Jul 1, 2024
@tvdeyen tvdeyen requested a review from a team as a code owner July 1, 2024 12:30
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.99%. Comparing base (d387ba9) to head (b110fca).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2950   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files         232      232           
  Lines        6271     6273    +2     
=======================================
+ Hits         6020     6022    +2     
  Misses        251      251           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sascha-karnatz
Copy link
Copy Markdown
Contributor

One less js.erb - file

@tvdeyen tvdeyen merged commit c25b9b1 into main Jul 1, 2024
@tvdeyen tvdeyen deleted the turbo-frame-picture-dialog branch July 1, 2024 12:41
@alchemycms-bot alchemycms-bot bot mentioned this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants