Skip to content

Fix asset precompilation#3024

Merged
tvdeyen merged 4 commits intoAlchemyCMS:mainfrom
mamhoff:fix-asset-precompilation
Sep 4, 2024
Merged

Fix asset precompilation#3024
tvdeyen merged 4 commits intoAlchemyCMS:mainfrom
mamhoff:fix-asset-precompilation

Conversation

@mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Sep 4, 2024

What is this pull request for?

Fix asset precompilation in host apps with SassC in environments other than development. We were still using the old image-url Sass directive, whereas modern Sass/Sprockets can fingerprint assets referenced in URL directives directly.

Notable changes (remove if none)

Makes the current main branch deployable.

Screenshots

None :)

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

These are inline styles in the menubar partial now.
We can just  rely on the browser.
Current sprockets will replace the contents of url() statements in CSS
with their fingerprinted versions.
@mamhoff mamhoff requested a review from a team as a code owner September 4, 2024 15:24
@tvdeyen tvdeyen added this to the 7.3 milestone Sep 4, 2024
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tvdeyen tvdeyen enabled auto-merge September 4, 2024 15:26
@tvdeyen tvdeyen merged commit 7b9390a into AlchemyCMS:main Sep 4, 2024
@codecov
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (a13577a) to head (15a79fd).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3024   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         237      237           
  Lines        6404     6404           
=======================================
  Hits         6178     6178           
  Misses        226      226           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mamhoff mamhoff deleted the fix-asset-precompilation branch September 4, 2024 15:40
@alchemycms-bot alchemycms-bot bot mentioned this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants