Conversation
tvdeyen
force-pushed
the
remove-7x-deprecations
branch
from
d902821 to
4b47b69
Compare
These helpers have been deprecated in 7.x and now get removed.
tvdeyen
force-pushed
the
remove-7x-deprecations
branch
from
4b47b69 to
eceb4bd
Compare
Since the element view does not include a DOM id anymore we need to test the actual rendered ingredient content.
They have been deprecated and replaced by ActiveSupport::Current
They have been deprecated in favor of the resource table component
They have been replaced by `css_classes` in your ingredients settings.
tvdeyen
force-pushed
the
remove-7x-deprecations
branch
from
eceb4bd to
fbe82b4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3041 +/- ##
==========================================
+ Coverage 96.47% 96.63% +0.16%
==========================================
Files 237 236 -1
Lines 6405 6333 -72
==========================================
- Hits 6179 6120 -59
+ Misses 226 213 -13 ☔ View full report in Codecov by Sentry. |
sascha-karnatz
approved these changes
Sep 19, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Removes all code that has been deprecated in 7.x
Checklist