Use image_file extension as render format#3272
Merged
Conversation
tvdeyen
changed the title
Dragonfly stores the file extension in the "magic column" `image_file_format` and not actually the format (mime type). Deprecates `suffix` to align the method name with the other magic columns.
tvdeyen
force-pushed
the
image-file-extension
branch
from
b1aba65 to
8103401
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3272 +/- ##
=======================================
Coverage 96.86% 96.86%
=======================================
Files 268 268
Lines 6821 6823 +2
=======================================
+ Hits 6607 6609 +2
Misses 214 214 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Extracted from #2968
Dragonfly stores the file extension in the "magic column"
image_file_formatand not actually the format (mime type).Preparing for Active Storage.
Notable changes
Deprecates
suffixto align the method name with the othermagic columns.
Checklist