Use Alchemy.config accessors instead of hash key#3275
Merged
Conversation
tvdeyen
force-pushed
the
alchemy-config-accessors
branch
2 times, most recently
from
f8272f2 to
532cde8
Compare
tvdeyen
force-pushed
the
alchemy-config-accessors
branch
2 times, most recently
from
1866bec to
9fcf6ce
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3275 +/- ##
=======================================
Coverage ? 96.89%
=======================================
Files ? 266
Lines ? 6826
Branches ? 0
=======================================
Hits ? 6614
Misses ? 212
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mamhoff
approved these changes
Jun 25, 2025
Contributor
mamhoff
left a comment
mamhoff
left a comment
There was a problem hiding this comment.
It does read nicer, but I think we should support at least the hash syntax as well (so not deprecate it)
The latter is deprecated.
Using `Alchemy.config.get(:config_name)` is easier to find than `configuration`.
Unnecessary indirection
tvdeyen
force-pushed
the
alchemy-config-accessors
branch
from
8b6a5a6 to
e9aae0c
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Instead of
Alchemy.config.get(:some_config)we useAlchemy.config.some_config.Checklist