Use image_file_extension for picture variant rendering#3277
Merged
Conversation
In ActiveStorage the `image_file_format` will be the file mime type and not the file extension. Since Dragonfly uses the file extension as format in it's "magic column" we introduced the `image_file_extension` method in a previous commit, but now need to prepare the picture variant for the upcoming adapter.
tvdeyen
force-pushed
the
image_file_extension_picture_variant
branch
from
16132fb to
8e6070f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3277 +/- ##
=======================================
Coverage 96.88% 96.88%
=======================================
Files 267 267
Lines 6840 6840
=======================================
Hits 6627 6627
Misses 213 213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
In ActiveStorage the
image_file_formatwill be the file mime type and not the file extension.Since Dragonfly uses the file extension as format in it's "magic column" we introduced the
image_file_extensionmethod in a previous commit, but now need to prepare the picture variant for the upcoming adapter.Checklist