refactor(uploader): Do not use arguments in constructor#3299
Merged
Conversation
Using custom elements like this is no compliant to the spec. You must not have arguments passed to the constructor as the browser won't be able to do that. This prepares these file to be tested with Vitest instead of Jest.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3299 +/- ##
=======================================
Coverage 96.95% 96.95%
=======================================
Files 269 269
Lines 6962 6962
=======================================
Hits 6750 6750
Misses 212 212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Using custom elements like this is no compliant to the spec. You must not have arguments passed to the constructor as the browser won't be able to do that.
This prepares these file to be tested with Vitest instead of Jest.
Checklist