Skip to content

refactor(uploader): Do not use arguments in constructor#3299

Merged
tvdeyen merged 1 commit intomainfrom
refactor-uploader
Jul 4, 2025
Merged

refactor(uploader): Do not use arguments in constructor#3299
tvdeyen merged 1 commit intomainfrom
refactor-uploader

Conversation

@tvdeyen
Copy link
Copy Markdown
Member

@tvdeyen tvdeyen commented Jul 3, 2025

What is this pull request for?

Using custom elements like this is no compliant to the spec. You must not have arguments passed to the constructor as the browser won't be able to do that.

This prepares these file to be tested with Vitest instead of Jest.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

Using custom elements like this is no compliant to the spec.
You must not have arguments passed to the constructor
as the browser won't be able to do that.

This prepares these file to be tested with Vitest instead of
Jest.
@tvdeyen tvdeyen added this to the 8.0 milestone Jul 3, 2025
@tvdeyen tvdeyen requested a review from a team as a code owner July 3, 2025 09:56
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95%. Comparing base (41fac99) to head (3593068).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3299   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files         269      269           
  Lines        6962     6962           
=======================================
  Hits         6750     6750           
  Misses        212      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen merged commit 84d53a5 into main Jul 4, 2025
18 checks passed
@tvdeyen tvdeyen deleted the refactor-uploader branch July 4, 2025 07:54
@alchemycms-bot alchemycms-bot bot mentioned this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants