Conversation
`engine_name` does not seem to be available during reloading the app in all envs.
The storage adapter lives in a autoload folder (app), which reloads the class during dev mode, leading to undefined constants errors.
We do not need multiple `config.to_prepare` blocks.
The storage adapter shoul be set once during load and everytime we reload the app in dev mode. This way we have the same instance everywhere, but still get a new class instance during reloads, what we need for the class reloading to work in dev mode.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3318 +/- ##
==========================================
- Coverage 97.02% 97.02% -0.01%
==========================================
Files 274 274
Lines 7169 7168 -1
==========================================
- Hits 6956 6955 -1
Misses 213 213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Two fixes that make developer lives easier:
Checklist