Allow to configure url classes in Dragonfly adapter#3371
Merged
Conversation
Member
Author
|
Necessary for AlchemyCMS/alchemy-dragonfly-s3#25 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3371 +/- ##
==========================================
+ Coverage 97.14% 97.22% +0.08%
==========================================
Files 277 277
Lines 7248 7247 -1
==========================================
+ Hits 7041 7046 +5
+ Misses 207 201 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The `alchemy-dragonfly-s3` gem needs to be able to register its url classes.
This allows the `alchemy-dragonfly-s3` gem to build the `variant` without knowing its inner logic.
tvdeyen
force-pushed
the
dragonfly-adapter-configurable-url-classes
branch
from
ab5d718 to
d9a1dc8
Compare
We already have the config in the initializer and fresh install will complain about not having the `alchemy/config.yml` anymore, since we switched to a Ruby file based config.
sascha-karnatz
approved these changes
Sep 8, 2025
mamhoff
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
The
alchemy-dragonfly-s3gem needs to be able to register its url classes.Checklist