Conversation
sascha-karnatz
approved these changes
Sep 18, 2025
Contributor
sascha-karnatz
left a comment
sascha-karnatz
left a comment
There was a problem hiding this comment.
Looks good! Only the "build:css" command is very long.
Member
Author
Yes. Unfortunately the Sass team refuses to create a config file 😞 |
Member
Author
|
I will build this a bit different after talking with @sascha-karnatz IRL |
tvdeyen
force-pushed
the
more-css-bundles
branch
from
46d3891 to
1169b3e
Compare
With seperate theme files for light, dark and auto modes we are able to load the theme we want into other admins (ie. Solidus) while still keep the bundles as small as possible. The default `alchemy/theme.css` file includes both (dark and light) themes which switch by preferred color scheme. The dedicated `alchemy/light-theme` and `alchemy/dark-theme` can be loaded in situations where you want that explicit theme.
tvdeyen
force-pushed
the
more-css-bundles
branch
from
1169b3e to
ca51241
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3379 +/- ##
=======================================
Coverage 97.22% 97.22%
=======================================
Files 277 277
Lines 7254 7254
=======================================
Hits 7053 7053
Misses 201 201 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
With seperate theme files for light, dark and auto modes we are able to load the theme
we want into other admins (ie. Solidus) while still keep the bundles as small as possible.
The default
alchemy/theme.cssfile includes both (dark and light) themes whichswitch by preferred color scheme.
The dedicated
alchemy/light-themeandalchemy/dark-themecan be loaded in situationswhere you want that explicit theme.
Checklist