Restrict language destroy if nodes present#3383
Merged
Conversation
sascha-karnatz
approved these changes
Sep 29, 2025
Rails has a this feature built in. Let's use it.
We must not allow to remove a language which is still attached to a menu node.
Rails has a this feature built in. Let's use it.
Rails has a this feature built in. Let's use it.
Adding the i18n-debug gem, but disable it so it does not clutter the logs. Enable it with `require: "i1n8/debug"`
2dd286f to
2d282fd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3383 +/- ##
==========================================
- Coverage 97.00% 96.99% -0.01%
==========================================
Files 277 277
Lines 7271 7262 -9
==========================================
- Hits 7053 7044 -9
Misses 218 218 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
This dissallows to remove a language if menu nodes are still attached.
Also refactors existing checks into Rails built-ins by using
dependent: :restrict_with_errorover a custom
before_destroyhook.Checklist