Skip to content

Make permissions.rb autoloadable#3419

Merged
tvdeyen merged 1 commit intoAlchemyCMS:mainfrom
mamhoff:autoloadable-permissions
Oct 11, 2025
Merged

Make permissions.rb autoloadable#3419
tvdeyen merged 1 commit intoAlchemyCMS:mainfrom
mamhoff:autoloadable-permissions

Conversation

@mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Oct 11, 2025

What is this pull request for?

CanCan abilities can be autoloaded and are only necessary at runtime. No need to load them on startup.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

CanCan abilities can be autoloaded and are only necessary at runtime. No
need to load them on startup.
@mamhoff mamhoff requested a review from a team as a code owner October 11, 2025 10:12
@codecov
Copy link

codecov bot commented Oct 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.13%. Comparing base (1c4ac02) to head (411eda9).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3419      +/-   ##
==========================================
- Coverage   97.13%   97.13%   -0.01%     
==========================================
  Files         279      279              
  Lines        7366     7365       -1     
==========================================
- Hits         7155     7154       -1     
  Misses        211      211              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen merged commit 0972127 into AlchemyCMS:main Oct 11, 2025
18 checks passed
@tvdeyen
Copy link
Member

tvdeyen commented Oct 11, 2025

@mamhoff does this need to be backported to 8.0 or is this fine as is and just an optimisation?

@mamhoff
Copy link
Contributor Author

mamhoff commented Oct 11, 2025

This is really an optimisation. No need to backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants