Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3456 +/- ##
=======================================
Coverage 97.42% 97.43%
=======================================
Files 314 314
Lines 8170 8172 +2
=======================================
+ Hits 7960 7962 +2
Misses 210 210 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9241cdd to
65feb78
Compare
112029d to
638ed3d
Compare
cac3893 to
2e50fbe
Compare
`namespace` is broken with a options hash and creates double nested `admin/admin` routes and `scope` emits an deprecation warning.
Rails 8.1 changed how attribute getters get defined and this broke the hint getter method from the Alchemy::Hints module. Simply moving it below the attribute definition fixed the issue.
…havior Since Rails 8.1 the SQLite Adapter returns database columns in different order on different platforms (macOS vs Linux). This caused the generated Ransack search field name to differ between local development and CI, leading to parameter filtering mismatches where permitted params on the server didn't match the field names sent by the client. By sorting searchable_attribute_names, the generated search_field_name is now deterministic regardless of the underlying database column order. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
…compatibility Ransack requires ransackable_associations to be defined on ActiveStorage::Blob when the association-traversing attribute appears first in a compound search predicate. With sorted searchable attribute names, the field name changed from name_or_image_file_blob_filename_cont to image_file_blob_filename_or_name_cont, which triggers this Ransack validation.
mamhoff
approved these changes
Jan 22, 2026
This was referenced Feb 4, 2026
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Allows the latest version of Rails (8.1). Some changes has to be made to how searchable attributes are build
for ransack search, because sqlite has a different column order on linux then on macos.
Checklist