Convert page_publication_fields into custom element#3484
Merged
Conversation
Much better to have a self contained html element that handles it’s own inner state instead of having to init the addEventListener for a custom dialog event which we have to set up on each page where the page configure dialog might be used. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3484 +/- ##
=======================================
Coverage 97.14% 97.14%
=======================================
Files 279 279
Lines 7391 7391
=======================================
Hits 7180 7180
Misses 211 211 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Feb 4, 2026
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Much better to have a self contained html element
that handles it’s own inner state instead of having to init the addEventListener for a custom dialog event which we have to set up on each page where the page configure dialog might be used.
Checklist