Skip to content

Add sorting select to Attachments Library#3487

Merged
tvdeyen merged 3 commits intomainfrom
attachments-sorting
Nov 24, 2025
Merged

Add sorting select to Attachments Library#3487
tvdeyen merged 3 commits intomainfrom
attachments-sorting

Conversation

@tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Nov 24, 2025

What is this pull request for?

Same as #3369 but for attachments

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Same as with images we also want users to see the latest
attachment first and let them decide if they want by
name instead.

Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
We need to tell Chrome the accepted language if
the OS is set to German, but we want to test in
English.

Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
@tvdeyen tvdeyen requested a review from a team as a code owner November 24, 2025 10:32
@tvdeyen tvdeyen added the backport-to-8.0-stable Needs to be backported to 8.0-stable label Nov 24, 2025
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.14%. Comparing base (bd52101) to head (9844c79).
⚠️ Report is 259 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3487   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files         279      279           
  Lines        7391     7393    +2     
=======================================
+ Hits         7180     7182    +2     
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen merged commit 819af01 into main Nov 24, 2025
18 checks passed
@tvdeyen tvdeyen deleted the attachments-sorting branch November 24, 2025 12:58
@alchemycms-bot
Copy link

💔 All backports failed

Status Branch Result
8.0-stable Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 3487

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@tvdeyen tvdeyen removed the backport-to-8.0-stable Needs to be backported to 8.0-stable label Nov 24, 2025
@tvdeyen tvdeyen added this to the 8.1 milestone Nov 24, 2025
@tvdeyen tvdeyen added the enhancement New feature or enhancement label Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants