Merged
Conversation
tvdeyen
force-pushed
the
picture-editor-component
branch
from
55aa272 to
ebf9123
Compare
No need to init from outside. The browser is very good at this for custom elements. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
When you press Enter in an input field inside a form, browsers automatically submit the form by triggering a click on the first button they find. Since the deleteButton is a <button> element without an explicit type attribute, it defaults to type="submit", which makes it a target for Enter key submissions. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
appendChild will not remove the existing placeholder. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
tvdeyen
force-pushed
the
picture-editor-component
branch
from
ebf9123 to
597db84
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3538 +/- ##
=======================================
Coverage 97.21% 97.21%
=======================================
Files 288 288
Lines 7608 7608
=======================================
Hits 7396 7396
Misses 212 212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sascha-karnatz
approved these changes
Dec 24, 2025
This was referenced Feb 4, 2026
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Converts the ingredient picture editor into a custom element.
Also fix a bug that was introduced in #3509 e5d8896
Checklist