Skip to content

Convert ElementEditor to ViewComponent#3547

Merged
tvdeyen merged 1 commit intomainfrom
element-editor-view-component
Jan 9, 2026
Merged

Convert ElementEditor to ViewComponent#3547
tvdeyen merged 1 commit intomainfrom
element-editor-view-component

Conversation

@tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jan 1, 2026

What is this pull request for?

Replace the ElementEditor decorator and _element.html.erb partial with
a single Alchemy::Admin::ElementEditor ViewComponent.

This consolidates view-specific logic and template rendering into one
component, following the pattern established by ingredient editor
components.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen self-assigned this Jan 1, 2026
@tvdeyen tvdeyen added this to the 8.1 milestone Jan 1, 2026
@codecov
Copy link

codecov bot commented Jan 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.35%. Comparing base (5ccb781) to head (c290058).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3547   +/-   ##
=======================================
  Coverage   97.35%   97.35%           
=======================================
  Files         308      308           
  Lines        8010     8011    +1     
=======================================
+ Hits         7798     7799    +1     
  Misses        212      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen force-pushed the element-editor-view-component branch 4 times, most recently from 52465fb to 6e9b219 Compare January 8, 2026 15:36
@tvdeyen tvdeyen marked this pull request as ready for review January 8, 2026 15:39
@tvdeyen tvdeyen requested a review from a team as a code owner January 8, 2026 15:39
@tvdeyen tvdeyen changed the title Element editor view component Convert ElementEditor to ViewComponent Jan 8, 2026
@tvdeyen tvdeyen removed their assignment Jan 8, 2026
Replace the ElementEditor decorator and _element.html.erb partial with
a single Alchemy::Admin::ElementEditor ViewComponent.

This consolidates view-specific logic and template rendering into one
component, following the pattern established by ingredient editor
components.
@tvdeyen tvdeyen force-pushed the element-editor-view-component branch from 6e9b219 to c290058 Compare January 9, 2026 11:00
Copy link
Contributor

@sascha-karnatz sascha-karnatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@tvdeyen tvdeyen merged commit 5a0ac20 into main Jan 9, 2026
19 checks passed
@tvdeyen tvdeyen deleted the element-editor-view-component branch January 9, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants