Merged
Conversation
tvdeyen
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3557 +/- ##
=======================================
Coverage 97.35% 97.35%
=======================================
Files 308 308
Lines 8011 8025 +14
=======================================
+ Hits 7799 7813 +14
Misses 212 212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Log an actual warning and not debug message. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
This adds a nice little `[alchemy]` log tag. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Rails logger does not support backtraces. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Use `Alchemy::Logger.warn` instead. This let's use get rid of the Alchemy::Logger includes in several places. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Add debug, error and info log levels. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Alchemy::Logger uses Rails.logger, but tagged with `[alchemy]`. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Be a bit more helpful. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
For warnings and errors we add the Type as prefix, so it easier to visually parse in logs. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
tvdeyen
force-pushed
the
alchemy-logger-proper
branch
from
c698aad to
da01802
Compare
This was referenced Feb 4, 2026
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Uses Rails' tagged logging and adds more log levels, so that logging inside of Alchemy is better structured
and better consumable by log subscribers.
Notable changes
Deprecates the second argument (stack trace) to
Alchemy::Logger.warnChecklist