Add publish button with version status#3558
Merged
Conversation
tvdeyen
force-pushed
the
publish-page-button
branch
2 times, most recently
from
af59aec to
b6e59f9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3558 +/- ##
=======================================
Coverage 97.35% 97.36%
=======================================
Files 308 309 +1
Lines 8025 8054 +29
=======================================
+ Hits 7813 7842 +29
Misses 212 212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
force-pushed
the
publish-page-button
branch
2 times, most recently
from
378ae9d to
aa5bbfe
Compare
Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
tvdeyen
force-pushed
the
publish-page-button
branch
from
aa5bbfe to
da10ddb
Compare
Page editors need visibility into whether they're working on unpublished changes. This replaces the simple publish button with a button that indicates when the draft version has changes not yet published. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
With the publish element button now having a tooltip, we need to make it sure is visible. The element window was placed on z-index: 20 in order to show the element window toolbar tooltips. Placing them under the button allows to remove the z-index, so the publish button tooltip is now visible. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Due to the fact that page publishing runs in a background worker, the public version has not been updated yet. We want the button to be disabled in this case, no matter what. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Same as our own button Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Now that we have the publish page button on the top right corner, the growl messages are blocking interaction with it. The bottom center is the less intrusive, while still prominent place. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Rubocop says this is slow Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
The page version meta data columns need to exist before we try to migrate it. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
This change needs to be published as well, to take effect on a public page. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Page meta data now lives on the page version. We need to publish this to be effective. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
tvdeyen
force-pushed
the
publish-page-button
branch
from
da10ddb to
ed6b011
Compare
Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
sascha-karnatz
approved these changes
Jan 16, 2026
This was referenced Feb 4, 2026
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Page editors need visibility into whether they're working on unpublished
changes. This replaces the simple publish button with a button that
indicates when the draft version has changes not yet published.
Notable changes
The publish changes button has been moved to the right side of the toolbar, right where the content is edited.
For that to work well Alchemy's growl notifications (toast notifications where called growl back in the day) are now placed in the bottom center of the screen to make room for interactions in the toolbars that are on the top of the screen.
Screenshots
Checklist