Skip to content

feat: Convert FileEditors.js into a custom element#3559

Merged
tvdeyen merged 2 commits intomainfrom
file-editor-component
Jan 15, 2026
Merged

feat: Convert FileEditors.js into a custom element#3559
tvdeyen merged 2 commits intomainfrom
file-editor-component

Conversation

@tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jan 14, 2026

What is this pull request for?

Easy conversion! No need to init it anymore, as custom elements are initialized by the browser.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

This is a leftover from the alchemy-picture-editor
refactoring.

Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Easy conversion! No need to init it a ymore,
as custom elements are initialized by the browser.

Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
@tvdeyen tvdeyen added this to the 8.1 milestone Jan 14, 2026
@tvdeyen tvdeyen requested a review from a team as a code owner January 14, 2026 18:09
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.35%. Comparing base (c2a84aa) to head (a89d9f6).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3559   +/-   ##
=======================================
  Coverage   97.35%   97.35%           
=======================================
  Files         308      308           
  Lines        8025     8025           
=======================================
  Hits         7813     7813           
  Misses        212      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen merged commit e01d6d8 into main Jan 15, 2026
19 checks passed
@tvdeyen tvdeyen deleted the file-editor-component branch January 15, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant