Fix CI workflow to detect package.json changes for Dependabot PRs#3572
Merged
Fix CI workflow to detect package.json changes for Dependabot PRs#3572
Conversation
The workflow was checking if bun.lockdb changed, but Dependabot only updates package.json. Now checks for package.json changes and commits both the updated bun.lockdb and vendor/javascript bundles.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3572 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 312 312
Lines 8087 8087
=======================================
Hits 7875 7875
Misses 212 212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The job only needs git to check changed files, no need to install Bun or run bun install.
Use github.event.pull_request.base.sha for PRs and github.event.before for push events.
Ensures cache invalidates when package.json changes, even if bun.lockdb hasn't been committed yet (e.g., Dependabot PRs).
- Add dependency on check_package_json and build_javascript jobs - Download bun.lockdb artifact when package.json changed - Add package.json to cache key
Member
Author
|
tested with #3571 |
This was referenced Feb 4, 2026
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
The workflow was checking if bun.lockdb changed, but Dependabot only updates package.json. Now checks for package.json changes and commits both the updated bun.lockdb and vendor/javascript bundles.
Checklist