Merged
Conversation
tvdeyen
force-pushed
the
element-publication-dates
branch
4 times, most recently
from
df7a033 to
7f8fa6b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3573 +/- ##
==========================================
+ Coverage 97.37% 97.40% +0.02%
==========================================
Files 312 314 +2
Lines 8091 8174 +83
==========================================
+ Hits 7879 7962 +83
Misses 212 212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
force-pushed
the
element-publication-dates
branch
4 times, most recently
from
4c7fc31 to
8139f7a
Compare
tvdeyen
changed the title
tvdeyen
force-pushed
the
element-publication-dates
branch
from
8139f7a to
5e69e09
Compare
sascha-karnatz
approved these changes
Jan 21, 2026
tvdeyen
force-pushed
the
element-publication-dates
branch
from
5e69e09 to
da842af
Compare
Useful if other models want to implement time based publishing. This slightly changes a) scope names (draft vs drafts) and the meaning of the public page version. Currently a page was considered public if any version exists that has a non NULL public_on time. Now it correctly looks for versions that are public now. Since we currently do not have more than one public version, this was never an issue, but with a future where multiple public page versions exist this is the right thing. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
This adds two timestamps public_on and public_until instead of the current public boolean. The toggle switch on the element editor remains a switch, but instead of a true/false value we now use the date of publication. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
tvdeyen
force-pushed
the
element-publication-dates
branch
from
da842af to
f362948
Compare
mamhoff
approved these changes
Jan 21, 2026
This was referenced Feb 4, 2026
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
This adds two timestamps
public_onandpublic_untilinstead of the currentpublicboolean.The toggle switch on the element editor remains a switch, but instead of a true/false value we now
use the date of publication.
Notable changes
Alchemy::PageVersion.draftandAlchemy::PageVersion.public_onscopes.Alchemy::Element.hiddenscope.Screenshots
Remove if no visual changes have been made.
Checklist