Skip to content

[8.0-stable] Fix elements generator#3591

Merged
tvdeyen merged 2 commits into8.0-stablefrom
backport/8.0-stable/pr-3590
Jan 23, 2026
Merged

[8.0-stable] Fix elements generator#3591
tvdeyen merged 2 commits into8.0-stablefrom
backport/8.0-stable/pr-3590

Conversation

@alchemycms-bot
Copy link

Backport

This will backport the following commits from main to 8.0-stable:

Questions ?

Please refer to the Backport tool documentation

ElementDefinition and IngredientDefinition now support hash-like
attribute access via delegate :[], to: :attributes. This allows
code to use definition["name"] syntax for compatibility with
templates and generators that expect hash-like access.

(cherry picked from commit 684c9ad)
The generator was calling load_alchemy_yaml which returns raw hashes,
but the template accessed attributes like .name on them. Now uses
ElementDefinition.all which returns proper definition objects.

(cherry picked from commit 0fab3b4)
@alchemycms-bot alchemycms-bot bot requested a review from a team as a code owner January 23, 2026 14:28
@alchemycms-bot alchemycms-bot bot mentioned this pull request Jan 23, 2026
3 tasks
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.20%. Comparing base (a97a5ba) to head (10d8791).
⚠️ Report is 4 commits behind head on 8.0-stable.

Additional details and impacted files
@@             Coverage Diff             @@
##           8.0-stable    #3591   +/-   ##
===========================================
  Coverage       97.20%   97.20%           
===========================================
  Files             288      288           
  Lines            7573     7575    +2     
===========================================
+ Hits             7361     7363    +2     
  Misses            212      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen merged commit 22070f6 into 8.0-stable Jan 23, 2026
15 of 16 checks passed
@tvdeyen tvdeyen deleted the backport/8.0-stable/pr-3590 branch January 23, 2026 14:35
@alchemycms-bot alchemycms-bot bot mentioned this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant