Skip to content

Include future-scheduled elements when publishing pages#3592

Merged
tvdeyen merged 1 commit intomainfrom
publish-future-scheduled-elements
Jan 26, 2026
Merged

Include future-scheduled elements when publishing pages#3592
tvdeyen merged 1 commit intomainfrom
publish-future-scheduled-elements

Conversation

@tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jan 23, 2026

What is this pull request for?

Previously, only currently visible elements were copied to the public version when publishing a page. This meant elements scheduled for future publication required a republish once their public_on date arrived.

Now the publisher copies all publishable elements, which includes both currently visible elements and those scheduled for the future. This allows elements with a future public_on date to automatically become visible once their scheduled time passes without requiring a republish.

Notable changes

  • Add publishable? method to Publishable concern
  • Add publishable filter to ElementsRepository
  • Update Publisher to use publishable instead of visible

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen added this to the 8.1 milestone Jan 23, 2026
@tvdeyen tvdeyen requested a review from a team as a code owner January 23, 2026 15:31
@tvdeyen tvdeyen marked this pull request as draft January 23, 2026 15:33
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.44%. Comparing base (0f0872b) to head (c395e7a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3592   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files         314      314           
  Lines        8190     8194    +4     
=======================================
+ Hits         7981     7985    +4     
  Misses        209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen force-pushed the publish-future-scheduled-elements branch from 2120c94 to 4f39a73 Compare January 23, 2026 16:58
@tvdeyen tvdeyen changed the base branch from main to backport-nested-elements-filter-8.0 January 23, 2026 16:58
@tvdeyen tvdeyen marked this pull request as ready for review January 23, 2026 17:02
Base automatically changed from backport-nested-elements-filter-8.0 to main January 26, 2026 08:36
Previously, only currently visible elements were copied to the public
version when publishing a page. This meant elements scheduled for future
publication required a republish once their public_on date arrived.

Now the publisher copies all publishable elements, which includes both
currently visible elements and those scheduled for the future. This
allows elements with a future public_on date to automatically become
visible once their scheduled time passes without requiring a republish.
@tvdeyen tvdeyen force-pushed the publish-future-scheduled-elements branch from 4f39a73 to c395e7a Compare January 26, 2026 09:31
@tvdeyen tvdeyen enabled auto-merge January 26, 2026 09:31
@tvdeyen tvdeyen merged commit ae102ea into main Jan 26, 2026
21 of 22 checks passed
@tvdeyen tvdeyen deleted the publish-future-scheduled-elements branch January 26, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants