Optimize page tree rendering performance#3606
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3606 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 314 314
Lines 8228 8240 +12
=======================================
+ Hits 8020 8032 +12
Misses 208 208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pre-compute URL templates once at the class level and substitute page IDs using simple string operations instead of calling Rails URL helpers for each page. This reduces the overhead of route matching which was showing up as a significant portion of render time in profiling. For a tree with 1000 pages, this reduces render time from ~725ms to ~420ms (approximately 40% improvement).
Cache repeated translation lookups in a frozen hash at the class level. Translations like "Your user role does not allow you to edit this page" were being looked up 6 times per page (6000 times for 1000 pages). Combined with the URL optimization, render time for 1000 pages improves from ~725ms to ~330ms (approximately 54% faster).
076b2f9 to
a1b9e28
Compare
sascha-karnatz
approved these changes
Jan 29, 2026
This was referenced Feb 4, 2026
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Pre-compute URL templates once at the class level and substitute page IDs
using simple string operations instead of calling Rails URL helpers for
each page. This reduces the overhead of route matching which was showing
up as a significant portion of render time in profiling.
For a tree with 1000 pages, this reduces render time from ~725ms to ~420ms
(approximately 40% improvement).
Cache repeated translation lookups in a frozen hash at the class level.
Translations like "Your user role does not allow you to edit this page"
were being looked up 6 times per page (6000 times for 1000 pages).
Combined with the URL optimization, render time for 1000 pages improves
from ~725ms to ~330ms (approximately 54% faster).
Checklist