Add sitemap.xml to show_page_in_sitemap translation#3744
Open
antwertinger wants to merge 1 commit intoAlchemyCMS:mainfrom
Open
Add sitemap.xml to show_page_in_sitemap translation#3744antwertinger wants to merge 1 commit intoAlchemyCMS:mainfrom
antwertinger wants to merge 1 commit intoAlchemyCMS:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3744 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 317 317
Lines 8428 8428
=======================================
Hits 8215 8215
Misses 213 213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
requested changes
Mar 13, 2026
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
Let's use the term Google uses in their docs
| show_eq: "Show EQ" | ||
| show_navigation: "Show in navigation" | ||
| show_page_in_sitemap: "Show page in sitemap." | ||
| show_page_in_sitemap: "Show page in sitemap.xml." |
Member
There was a problem hiding this comment.
sitemap.xml is a very technical term. I would like to avoid it.
Google Search Console and most SEO Tools use the term "XML Sitemap", so it should be widely known.
Suggested change
| show_page_in_sitemap: "Show page in sitemap.xml." | |
| show_page_in_sitemap: "Show Page in XML Sitemap" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Clarify show_page_in_sitemap label to reference sitemap.xml explicitly
The previous translations for the show_page_in_sitemap checkbox label were vague (e.g. "Show page in sitemap"). It was not immediately clear to users what file or system was affected.
By including sitemap.xml literally, the label now clearly communicates that checking this option controls whether the page appears in the sitemap.xml file — making the checkbox's purpose unambiguous regardless of the user's language.
Checklist