Added Resolvable protocol#57
Merged
Merged
Conversation
ilyapuchka
force-pushed
the
feature/resolve-dependencies-callback
branch
from
14cc2a3 to
99315e3
Compare
ilyapuchka
added a commit
that referenced
this pull request
Mar 18, 2016
…callback Added Resolvable protocol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #56
+/-:
+: separation of component definition from it's dependencies usage;
+: we currently perform auto-injections after calling
resolveDependenciesblock, so even at the end ofresolveDependenciesblock some of the dependencies could be not yet resolved. Actually the order of these two operations does not change anything functionality-wise, but changes what instances would be reused - auto-injected or resolved manually;-: Conformance to
Resolvableprotocol introduces dependency on Dip.