Skip to content

Removed PHI network and associated items from dapps list#2952

Merged
seabornlee merged 1 commit intomasterfrom
remove-phi-network
Nov 17, 2022
Merged

Removed PHI network and associated items from dapps list#2952
seabornlee merged 1 commit intomasterfrom
remove-phi-network

Conversation

@justindg
Copy link
Contributor

Removed PHI network and associated items from dapps list.

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments
seabornlee
🥇
14
▀▀▀▀
3h 36m
10
▀▀▀▀▀▀
JamesSmartCell
🥈
12
▀▀▀▀
1d 41m
▀▀▀▀
7
▀▀▀▀
justindg
🥉
8
▀▀
1d 5h 2m
▀▀▀▀▀
1

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 7.62% // Head: 7.61% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (5a5dfe1) compared to base (7784baa).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #2952      +/-   ##
===========================================
- Coverage      7.62%   7.61%   -0.02%     
  Complexity      836     836              
===========================================
  Files           612     612              
  Lines         41863   41823      -40     
  Branches       4226    4223       -3     
===========================================
- Hits           3194    3185       -9     
+ Misses        38395   38364      -31     
  Partials        274     274              
Impacted Files Coverage Δ
app/src/main/java/com/alphawallet/app/C.java 57.14% <ø> (ø)
...ava/com/alphawallet/app/service/TickerService.java 18.40% <ø> (+1.40%) ⬆️
...lphawallet/app/repository/EthereumNetworkBase.java 52.56% <100.00%> (-0.90%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seabornlee seabornlee merged commit 015569c into master Nov 17, 2022
@seabornlee seabornlee deleted the remove-phi-network branch November 17, 2022 01:21
seabornlee pushed a commit that referenced this pull request Nov 17, 2022
@Phinetwork

This comment was marked as abuse.

JamesSmartCell pushed a commit that referenced this pull request Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants