Skip to content

Fix most of the crashes#2956

Merged
JamesSmartCell merged 8 commits intomasterfrom
fix-crash
Nov 18, 2022
Merged

Fix most of the crashes#2956
JamesSmartCell merged 8 commits intomasterfrom
fix-crash

Conversation

@seabornlee
Copy link
Contributor

  • Fix NPE
  • Fix IndexOutOfBoundsException
  • Fix NPE
  • Fix NPE
  • Fix NPE
  • Fix NPE
  • Fix NPE
  • Fix NPE

@seabornlee seabornlee marked this pull request as ready for review November 18, 2022 17:08
@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments
seabornlee
🥇
15
▀▀▀▀
3h 35m
10
▀▀▀▀▀▀
JamesSmartCell
🥈
12
▀▀▀
1d 41m
▀▀▀▀▀
7
▀▀▀▀
justindg
🥉
9
▀▀▀
22h 42m
▀▀▀▀
1

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 7.61% // Head: 7.61% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (0df8e47) compared to base (2d815f4).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #2956      +/-   ##
===========================================
- Coverage      7.61%   7.61%   -0.01%     
  Complexity      836     836              
===========================================
  Files           612     612              
  Lines         41823   41836      +13     
  Branches       4223    4228       +5     
===========================================
  Hits           3185    3185              
- Misses        38364   38377      +13     
  Partials        274     274              
Impacted Files Coverage Δ
...entity/walletconnect/WalletConnectSessionItem.java 0.00% <0.00%> (ø)
...va/com/alphawallet/app/ui/DappBrowserFragment.java 0.22% <0.00%> (ø)
...phawallet/app/ui/QRScanning/QRScannerActivity.java 0.00% <0.00%> (ø)
...main/java/com/alphawallet/app/ui/SwapActivity.java 0.00% <0.00%> (ø)
.../com/alphawallet/app/ui/WalletActionsActivity.java 0.00% <0.00%> (ø)
...phawallet/app/ui/WalletConnectSessionActivity.java 0.00% <0.00%> (ø)
.../ui/widget/adapter/SingleSelectNetworkAdapter.java 0.00% <0.00%> (ø)
...ain/java/com/alphawallet/app/widget/GasWidget.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JamesSmartCell JamesSmartCell merged commit cec5527 into master Nov 18, 2022
@JamesSmartCell JamesSmartCell deleted the fix-crash branch November 18, 2022 23:03
JamesSmartCell pushed a commit that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants