Skip to content

Conversation

@bhelm
Copy link
Contributor

@bhelm bhelm commented Oct 24, 2025

Im sorry that this is one PR for two features. I have two inverters and needed them running again quickly after the firmware update, so i need it both in one branch.

the IDENT_POSTFIX ENV gets appended to unique identifiers, allowing for multiple tripower X to be integrated (see README).

the 03.14.22.R compatibility is basicly float-casting float-looking values.

@bhelm
Copy link
Contributor Author

bhelm commented Oct 24, 2025

fixes #61 and #58

Copy link
Owner

@AnotherDaniel AnotherDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - I can't test this myself, having only one inverter and zero evchargers on my end. But we will have to investigate what the CI is complaining about,

@AnotherDaniel
Copy link
Owner

AnotherDaniel commented Oct 24, 2025

Hm - Python apparently has moved on since I looked at this, and there's some breaking changes in the linter?
(https://github.com/AnotherDaniel/smahub/actions/runs/18788667882/job/53616571416?pr=62)
I've done a first pass at this in #63, but haven't tested it yet - tomorrow...
(Python is such a brittle heap of stuff build on a foundation of sand, it feels like - if we do a smahub v2, that will be Rust of Elixir ;-) )

Wdyt - fix these items in the scope of this PR, to make things build again? Or should I test, merge, and you do a rebase?

Oh! - and THANK YOU so much for doing this contribution!

@bhelm
Copy link
Contributor Author

bhelm commented Oct 25, 2025

You can merge and i will rebase then, no problem.

@AnotherDaniel
Copy link
Owner

Ok. Only hold-up is that I haven't gotten around to testing my branch with those changes today. Which I really should do in this case. Grab my changes from the PR branch if you want to run/test this yourself - I'll put a marker in for tomorrow to give it a go.

@devfaz
Copy link

devfaz commented Oct 26, 2025

@bhelm thx a lot for your fix and of course @AnotherDaniel for the project 👍 :)

@bhelm
Copy link
Contributor Author

bhelm commented Oct 27, 2025

I have merged your branch and deployed the result to my HA installation. When the sun (hopefully) comes out tomorrow, i can see if everything works as expected. currently, it runs and does not throw errors.

@AnotherDaniel
Copy link
Owner

Ok - I've merged my branch after also doing some testing.

@AnotherDaniel AnotherDaniel merged commit d36971d into AnotherDaniel:main Oct 27, 2025
2 of 5 checks passed
@AnotherDaniel
Copy link
Owner

There is a release v1.7.0 with your changes in - hope it works for everyone, and thank you again for contributing this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants