-
Notifications
You must be signed in to change notification settings - Fork 12
03.14.22.R compatibility, multiple inverter support #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated logging levels for parameter values and streamlined value conversion.
AnotherDaniel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good - I can't test this myself, having only one inverter and zero evchargers on my end. But we will have to investigate what the CI is complaining about,
|
Hm - Python apparently has moved on since I looked at this, and there's some breaking changes in the linter? Wdyt - fix these items in the scope of this PR, to make things build again? Or should I test, merge, and you do a rebase? Oh! - and THANK YOU so much for doing this contribution! |
|
You can merge and i will rebase then, no problem. |
|
Ok. Only hold-up is that I haven't gotten around to testing my branch with those changes today. Which I really should do in this case. Grab my changes from the PR branch if you want to run/test this yourself - I'll put a marker in for tomorrow to give it a go. |
|
@bhelm thx a lot for your fix and of course @AnotherDaniel for the project 👍 :) |
|
I have merged your branch and deployed the result to my HA installation. When the sun (hopefully) comes out tomorrow, i can see if everything works as expected. currently, it runs and does not throw errors. |
|
Ok - I've merged my branch after also doing some testing. |
|
There is a release v1.7.0 with your changes in - hope it works for everyone, and thank you again for contributing this PR! |
Im sorry that this is one PR for two features. I have two inverters and needed them running again quickly after the firmware update, so i need it both in one branch.
the IDENT_POSTFIX ENV gets appended to unique identifiers, allowing for multiple tripower X to be integrated (see README).
the 03.14.22.R compatibility is basicly float-casting float-looking values.