Skip to content

Fix base64 encoding#1482

Merged
heifner merged 2 commits into
mainfrom
GH-1461-base64
Aug 10, 2023
Merged

Fix base64 encoding#1482
heifner merged 2 commits into
mainfrom
GH-1461-base64

Conversation

@heifner

@heifner heifner commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

Remove the invalid addition of "=" to all base64 encoded strings from fc::variant.
Also update base64 implementation from: https://github.com/ReneNyffenegger/cpp-base64

Resolves #1461

@heifner heifner requested review from greg7mdp and linh2931 August 8, 2023 16:20

@spoonincode spoonincode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we ruled out boost's base64 impl, but can we use openssl's base64 instead of having our own impl?

@heifner

heifner commented Aug 8, 2023

Copy link
Copy Markdown
Contributor Author

I know we ruled out boost's base64 impl, but can we use openssl's base64 instead of having our own impl?

Doesn't seem to provide base64url_decode url decoding used by webauthn.

@linh2931 linh2931 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared with the upstream version. It looked good. Approve the PR if we decide use this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCI Work exclusive to OCI team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid Base64 padding returned by APIs

4 participants