Fix base64 encoding#1482
Merged
Merged
Conversation
spoonincode
previously requested changes
Aug 8, 2023
spoonincode
left a comment
Contributor
There was a problem hiding this comment.
I know we ruled out boost's base64 impl, but can we use openssl's base64 instead of having our own impl?
Contributor
Author
Doesn't seem to provide |
linh2931
approved these changes
Aug 8, 2023
linh2931
left a comment
Contributor
There was a problem hiding this comment.
I compared with the upstream version. It looked good. Approve the PR if we decide use this.
spoonincode
approved these changes
Aug 9, 2023
This was referenced Nov 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the invalid addition of "=" to all base64 encoded strings from
fc::variant.Also update base64 implementation from: https://github.com/ReneNyffenegger/cpp-base64
Resolves #1461