Adopt FakeTimeProvider#1350
Merged
martincostello merged 2 commits intoApp-vNext:mainfrom Jun 24, 2023
Merged
Conversation
martincostello
added
the
v8
Codecov Report
@@ Coverage Diff @@
## main #1350 +/- ##
=======================================
Coverage 83.59% 83.59%
=======================================
Files 270 270
Lines 6396 6396
Branches 1008 1008
=======================================
Hits 5347 5347
Misses 840 840
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. |
Use a source copy of `FakeTimeProvider` for tests that do not depend on cancellation behaviours or verify the implementation's internal calls.
Remove methods on `MockTimeProvider` that are unsed after the adoption of `FakeTimeProvider`.
martincostello
force-pushed
the
use-faketimeprovider
branch
from
518e354 to
9b4efc2
Compare
martintmk
approved these changes
Jun 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FakeTimeProviderfor tests that do not depend on cancellation behaviours or verify the implementation's internal calls. We can then drop this code as part of Add support for .NET 8 #1144 once Remove CancelAfter and Delay from internal TimeProvider #1348 is resolved.MockTimeProviderthat are unused after the adoption ofFakeTimeProvider.Builds on top of #1349.