Skip to content

Got rid of some warnings in the Polly project#1514

Merged
martincostello merged 3 commits intoApp-vNext:mainfrom
IgorIgorevich94:Cleanup-1290
Aug 28, 2023
Merged

Got rid of some warnings in the Polly project#1514
martincostello merged 3 commits intoApp-vNext:mainfrom
IgorIgorevich94:Cleanup-1290

Conversation

@IgorIgorevich94
Copy link
Contributor

@IgorIgorevich94 IgorIgorevich94 commented Aug 24, 2023

The issue or feature being addressed

Contributes to #1290

Details on the issue fix or feature implementation

Got rid of SA1129; SA1204; S3928; CA1508; CA1822; CA2201; SA1642 warnings in the Polly project

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@IgorIgorevich94
Copy link
Contributor Author

@dotnet-policy-service agree

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #1514 (2c49df8) into main (525d135) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is 86.11%.

@@           Coverage Diff           @@
##             main    #1514   +/-   ##
=======================================
  Coverage   84.10%   84.10%           
=======================================
  Files         277      277           
  Lines        6581     6581           
  Branches     1025     1025           
=======================================
  Hits         5535     5535           
  Misses        837      837           
  Partials      209      209           
Flag Coverage Δ
linux 84.10% <86.11%> (?)
macos ?
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Polly/CircuitBreaker/CircuitStateController.cs 93.93% <ø> (ø)
.../Polly/RateLimit/LockFreeTokenBucketRateLimiter.cs 82.75% <ø> (ø)
src/Polly/Registry/PolicyRegistry.cs 89.18% <0.00%> (ø)
src/Polly/AsyncPolicy.ContextAndKeys.cs 83.33% <50.00%> (ø)
src/Polly/Policy.ContextAndKeys.cs 83.33% <50.00%> (ø)
src/Polly/AsyncPolicy.ExecuteOverloads.cs 72.72% <100.00%> (ø)
src/Polly/AsyncPolicy.TResult.ExecuteOverloads.cs 75.86% <100.00%> (ø)
src/Polly/Policy.ExecuteOverloads.cs 86.36% <100.00%> (ø)
src/Polly/Policy.TResult.ExecuteOverloads.cs 87.50% <100.00%> (ø)
src/Polly/PolicyBase.ContextAndKeys.cs 100.00% <100.00%> (ø)
... and 3 more

@martintmk
Copy link
Contributor

@martincostello Is this OK to be merged?

@martincostello martincostello added this to the v8.0.0 milestone Aug 28, 2023
@martincostello martincostello added the v8 Issues related to the new version 8 of the Polly library. label Aug 28, 2023
Co-authored-by: Martin Costello <martin@martincostello.com>
@martincostello martincostello enabled auto-merge (squash) August 28, 2023 10:08
@martincostello martincostello enabled auto-merge (squash) August 28, 2023 10:09
@martincostello martincostello merged commit daf1529 into App-vNext:main Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 Issues related to the new version 8 of the Polly library.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants