Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1521 +/- ##
=======================================
Coverage 84.11% 84.11%
=======================================
Files 278 278
Lines 6586 6586
Branches 1026 1026
=======================================
Hits 5540 5540
Misses 837 837
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
martincostello
approved these changes
Aug 29, 2023
This was referenced Sep 29, 2025
This was referenced Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
HedgingDelay->Delay)RetryBackoffTypetoDelayBackoffTypeto make it more universal as it can be used by other strategies later.RetryCounttoMaxRetryAttemptsto make it alligned with hedging (MaxHedgingAttempts) and to make it clear that retry strategy can exit sooner than that.MaxHedgingAttemptswith value 1 is now valid. (the initial attempt does not count, similar to how retry strategy works)Contributes to #1507
Confirm the following