Skip to content

Fix documentation comment for CB's MinimumThroughput#1654

Merged
martincostello merged 2 commits intoApp-vNext:mainfrom
peter-csala:fix-MinimumThroughput-documentation-comment
Sep 28, 2023
Merged

Fix documentation comment for CB's MinimumThroughput#1654
martincostello merged 2 commits intoApp-vNext:mainfrom
peter-csala:fix-MinimumThroughput-documentation-comment

Conversation

@peter-csala
Copy link
Contributor

The issue or feature being addressed

  • NO ISSUE

Details on the issue fix or feature implementation

  • The documentation comment of MinimumThroughput contained wrong default value.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martincostello
Copy link
Member

Thanks!

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d7758d8) 84.63% compared to head (607a6a5) 84.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1654   +/-   ##
=======================================
  Coverage   84.63%   84.63%           
=======================================
  Files         306      306           
  Lines        6819     6819           
  Branches     1045     1045           
=======================================
  Hits         5771     5771           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 84.63% <ø> (ø)
macos 84.63% <ø> (ø)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...itBreaker/CircuitBreakerStrategyOptions.TResult.cs 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 679740d into App-vNext:main Sep 28, 2023
@peter-csala peter-csala deleted the fix-MinimumThroughput-documentation-comment branch October 31, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants