Merged
Conversation
Member
martincostello
commented
Dec 9, 2023
martincostello
commented
- Update NuGet packages to their latest versions while dependabot is unable to correctly do the updates (e.g. Bump the xunit group with 2 updates #1848).
- Fix/suppress new SonarAnalyzer.CSharp warnings.
- Update NuGet packages to their latest versions while dependabot is unable to correctly do the updates. - Fix/suppress new SonarAnalyzer.CSharp warnings.
martincostello
added
dependencies
Removing the "useless primary constructor" breaks code coverage as the empty records appears to be unused (when it is), so add it back and suppress the warning instead.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1849 +/- ##
=======================================
Coverage 84.58% 84.58%
=======================================
Files 308 308
Lines 6798 6798
Branches 1049 1049
=======================================
Hits 5750 5750
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
martintmk
approved these changes
Dec 10, 2023
martincostello
added a commit
that referenced
this pull request
Jan 4, 2024
- Update NuGet packages to their latest versions while dependabot is unable to correctly do the updates. - Fix/suppress new SonarAnalyzer.CSharp warnings.
This was referenced Aug 26, 2025
This was referenced Sep 29, 2025
This was referenced Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.