Fix potential github action smells by ceddy4395 · Pull Request #2097 · App-vNext/Polly

ceddy4395 · 2024-05-05T19:06:42Z

Pull Request

Hey! 🙂
I want to contribute the following changes to your workflow:

Use 'if' for upload-artifact action
Avoid uploading artifacts on forks
Prevent running issue/PR actions on forks
Avoid deploying jobs on forks

(These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more)

The issue or feature being addressed

Details on the issue fix or feature implementation

Confirm the following

I started this PR by branching from the head of the default branch
I have targeted the PR to merge into the default branch
I have included unit tests for the issue/feature
I have successfully run a local build

- Use 'if' for upload-artifact action - Avoid uploading artifacts on forks - Prevent running issue/PR actions on forks - Avoid deploying jobs on forks

.github/workflows/after-release.yml

.github/workflows/build.yml

gintsk · 2024-05-07T10:12:30Z

@martincostello is it really neccessary to run code-scan, ossf-scorecard and stale, etc actions in forks?
It seems that after recent changes all github workflows are enabled for running in forks.

martincostello · 2024-05-07T11:02:13Z

I didn't specifically disable it because my understanding was that GitHub automatically disables actions for new forks. This was something I used to do in all my own repos, but I've stopped because I thought the default didn't need it anymore. See https://github.com/orgs/community/discussions/26704#discussioncomment-3252979

If that isn't the case we can look to turn it off explicitly, but if we do so I would want to code to do it the way I suggested in my review, not with hard-coding the repository name: #2097 (comment)

Co-authored-by: Martin Costello <martin@martincostello.com>

.github/workflows/after-release.yml

.github/workflows/build.yml

Restore whitespace.

Disable three additional workflows on forks.

github-actions · 2024-06-28T13:51:41Z

Thanks for your contribution @ceddy4395 - the changes from this pull request have been published as part of version 8.4.1 📦, which is now available from NuGet.org 🚀

Fix gha smells:

ffa30b7

- Use 'if' for upload-artifact action - Avoid uploading artifacts on forks - Prevent running issue/PR actions on forks - Avoid deploying jobs on forks

ceddy4395 changed the title ~~Fix gha smells:~~ Fix potential github action smells May 5, 2024

martincostello reviewed May 5, 2024

View reviewed changes

.github/workflows/after-release.yml Outdated Show resolved Hide resolved

.github/workflows/build.yml Outdated Show resolved Hide resolved

.github/workflows/build.yml Outdated Show resolved Hide resolved

ceddy4395 and others added 2 commits May 13, 2024 10:30

Replace github.repository with github.event.repository.fork

a527256

Remove trailing space

29df784

Co-authored-by: Martin Costello <martin@martincostello.com>

martincostello reviewed May 13, 2024

View reviewed changes

.github/workflows/after-release.yml Outdated Show resolved Hide resolved

.github/workflows/build.yml Show resolved Hide resolved

ceddy4395 and others added 3 commits May 13, 2024 11:03

Revert preventing uploading artifacts on forks

d832365

Fix formatting

f78d0fd

Restore whitespace.

Disable workflows on forks

7415ae8

Disable three additional workflows on forks.

martincostello added this to the v8.4.1 milestone May 13, 2024

martincostello added enhancement CI/build github_actions Pull requests that update GitHub Actions code labels May 13, 2024

martincostello approved these changes May 13, 2024

View reviewed changes

martincostello enabled auto-merge (squash) May 13, 2024 09:24

martincostello merged commit eb5d8f6 into App-vNext:main May 13, 2024

dependabot bot mentioned this pull request Jul 23, 2025

Bump Discord.Net.Webhook and 7 others vinnie1234/HomeAutomation-NetDaemon#101

Closed

This was referenced Jul 30, 2025

Bump OpenTelemetry.Exporter.OpenTelemetryProtocol and 6 others takumi3488/ical2s3grpc#5

Merged

Bump the polly group with 1 update sandeep960/Core8#7

Closed

Bump Discord.Net.Webhook and 7 others vinnie1234/HomeAutomation-NetDaemon#102

Merged

dependabot bot mentioned this pull request Aug 18, 2025

Bump Polly from 7.2.3 to 8.6.2 QTNetModernization-5000-Repos/basistheory-dotnet_1#7

Closed

This was referenced Aug 26, 2025

Bump Polly from 7.2.3 to 8.6.3 QTNetModernization-5000-Repos/basistheory-dotnet_1#11

Closed

Bump Polly from 8.1.0 to 8.6.3 anddone-kit/AndDone-SecureAPI-ClientLibrary-DotNet#2

Closed

dependabot bot mentioned this pull request Sep 2, 2025

build: Bump Polly from 7.2.3 to 8.6.3 apimatic/core-lib-csharp#132

Closed

This was referenced Sep 29, 2025

Bump Polly from 7.2.3 to 8.6.4 QTNetModernization-5000-Repos/basistheory-dotnet_1#13

Open

build: Bump Polly from 7.2.3 to 8.6.4 apimatic/core-lib-csharp#154

Closed

Bump the polly group with 1 update sandeep960/Core8#12

Closed

dependabot bot mentioned this pull request Oct 6, 2025

Bump Polly from 8.1.0 to 8.6.4 anddone-kit/AndDone-SecureAPI-ClientLibrary-DotNet#7

Merged

dependabot bot mentioned this pull request Oct 27, 2025

deps: Bump Polly from 7.2.3 to 8.6.4 rivoli-ai/andy-guard#51

Closed

dependabot bot mentioned this pull request Nov 24, 2025

deps: Bump Polly from 7.2.3 to 8.6.5 rivoli-ai/andy-guard#65

Open

This was referenced Dec 8, 2025

Bump Polly from 8.2.1 to 8.6.5 Hau-Hau/Serilog.Extensions.WhenRepeated#6

Open

Bump Polly.Extensions from 8.0.0 to 8.6.5 smdn/Smdn.Fundamentals#287

Closed

This was referenced Dec 15, 2025

Bump Polly from 8.2.1 to 8.6.5 xjanova/PostXAgent#40

Closed

Bump Polly from 8.4.0 to 8.6.5 SkogsKrutt/test-repo#3

Merged

dependabot bot mentioned this pull request Jan 1, 2026

Bump the polly group with 1 update sandeep960/Core8#19

Open

This was referenced Jan 16, 2026

build: Bump Polly from 7.2.3 to 8.6.5 apimatic/core-lib-csharp#164

Open

Bump Polly from 7.2.3 to 8.6.5 AstraidLabs/Kitsub#51

Merged

Bump Polly from 8.2.0 to 8.6.5 clearlydefined/operations#208

Merged

dependabot bot mentioned this pull request Jan 29, 2026

Bump Polly from 7.2.4 to 8.6.5 AstraidLabs/Kitsub#72

Closed

dependabot bot mentioned this pull request Feb 16, 2026

Bump Polly from 8.1.0 to 8.6.5 anddone-kit/AndDone-SecureAPI-ClientLibrary-DotNet#17

Merged

This was referenced Mar 5, 2026

Bump Polly from 7.2.4 to 8.6.6 AstraidLabs/Kitsub#79

Open

chore(deps): Bump Polly from 8.2.1 to 8.6.6 xjanova/PostXAgent#159

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix potential github action smells#2097

Fix potential github action smells#2097
martincostello merged 6 commits intoApp-vNext:mainfrom
ceddy4395:fix-gha-smells

ceddy4395 commented May 5, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gintsk commented May 7, 2024

Uh oh!

martincostello commented May 7, 2024

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ceddy4395 commented May 5, 2024

Pull Request

The issue or feature being addressed

Details on the issue fix or feature implementation

Confirm the following

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gintsk commented May 7, 2024

Uh oh!

martincostello commented May 7, 2024

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants