Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2172 +/- ##
=======================================
Coverage 83.80% 83.80%
=======================================
Files 313 313
Lines 7161 7161
Branches 1060 1060
=======================================
Hits 6001 6001
Misses 789 789
Partials 371 371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| /// the key was found in the cache, and whose second element is the value from the cache (null if not found). | ||
| /// </returns> | ||
| Task<(bool, object?)> TryGetAsync(string key, CancellationToken cancellationToken, bool continueOnCapturedContext); | ||
| Task<(bool CacheHit, object? Result)> TryGetAsync(string key, CancellationToken cancellationToken, bool continueOnCapturedContext); |
There was a problem hiding this comment.
We can't make changes like this to the public interface. This is why the build is failing, because the public API no longer matches the baseline.
For public members, the warning just has to be suppressed. Otherwise it would be a breaking change for users.
There was a problem hiding this comment.
Really. I've done something stupid
There was a problem hiding this comment.
As noted in my previous comment, all these changes should be reverted.
If we wanted to make them (which we don't), they would go in the Unshipped file because these members don't exist in any shipped version.
Zombach
deleted the
zombach/remove-warning-sa1414-names-member-declaration
branch
2 participants
Pull Request
The issue or feature being addressed
#1290
Details on the issue fix or feature implementation
Confirm the following