Clean the Polly.Utils.ObjectPool class

src/Polly.Core/Utils/ObjectPool.cs

@@ -6,25 +6,15 @@ internal sealed class ObjectPool<T>
 {
     internal static readonly int MaxCapacity = (Environment.ProcessorCount * 2) - 1; // the - 1 is to account for _fastItem
 
-    private readonly Func<ObjectPool<T>, T> _createFunc;
+    private readonly Func<T> _createFunc;
     private readonly Func<T, bool> _returnFunc;
 
     private readonly ConcurrentQueue<T> _items = new();
 
     private T? _fastItem;
     private int _numItems;
 
-    public ObjectPool(Func<T> createFunc, Action<T> reset)
-        : this(createFunc, o => { reset(o); return true; })
-    {
-    }
-
     public ObjectPool(Func<T> createFunc, Func<T, bool> returnFunc)
-        : this(_ => createFunc(), returnFunc)
-    {
-    }
-
-    public ObjectPool(Func<ObjectPool<T>, T> createFunc, Func<T, bool> returnFunc)
     {
         _createFunc = createFunc;
         _returnFunc = returnFunc;
@@ -42,7 +32,7 @@ public T Get()
             }
 
             // no object available, so go get a brand new one
-            return _createFunc(this);
+            return _createFunc();
         }
 
         return item;

test/Polly.Core.Tests/Utils/ObjectPoolTests.cs

@@ -8,7 +8,7 @@ public class ObjectPoolTests
     public void GetAnd_ReturnObject_SameInstance()
     {
         // Arrange
-        var pool = new ObjectPool<object>(() => new object(), _ => { });
+        var pool = new ObjectPool<object>(() => new object(), _ => true);
 
         var obj1 = pool.Get();
         pool.Return(obj1);