Skip to content

Rate limiter#894

Closed
YarekTyshchenko wants to merge 27 commits intoApp-vNext:v723-or-v730from
YarekTyshchenko:RateLimiter
Closed

Rate limiter#894
YarekTyshchenko wants to merge 27 commits intoApp-vNext:v723-or-v730from
YarekTyshchenko:RateLimiter

Conversation

@YarekTyshchenko
Copy link
Copy Markdown

@YarekTyshchenko YarekTyshchenko commented Oct 15, 2021 •
edited
Loading

The issue or feature being addressed

This PR is a resurrection of #666 only because the author seems to be unreachable. Most of the work has already been done by @reisenberger

Solves Issue #260

Details on the issue fix or feature implementation

Confirm the following

  • I started this PR by branching from the head of the latest dev vX.Y branch, or I have rebased on the latest dev vX.Y branch, or I have merged the latest changes from the dev vX.Y branch
  • I have targeted the PR to merge into the latest dev vX.Y branch as the base branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@dnfadmin
Copy link
Copy Markdown

dnfadmin commented Oct 15, 2021 •
edited
Loading

CLA assistant check
All CLA requirements met.

@YarekTyshchenko YarekTyshchenko changed the base branch from master to v723-or-v730 October 15, 2021 10:10
reisenberger and others added 27 commits October 15, 2021 11:37
@reisenberger @YarekTyshchenko
Add core RateLimiter implementations
a506f02
@reisenberger @YarekTyshchenko
Add example async TResult rate-limiter policy implementation
e31aa32
@reisenberger @YarekTyshchenko
Add example syntax
12a276a
@reisenberger @YarekTyshchenko
Make the retryAfterFactory take Timespan as an input parameter!
6e2da28
@reisenberger @YarekTyshchenko
Initial LockFreeTokenBucketRateLimiterTests
f5435e4
@reisenberger @YarekTyshchenko
Factor out test helpers
adbefab
@reisenberger @YarekTyshchenko
Factor out common tests; add tests on lock-based rate limiter
29a63fa
@reisenberger @YarekTyshchenko
Allow for slow-running on CI servers
6ff0448
@reisenberger @YarekTyshchenko
Add tests on full bucket capacity
ead0d14
@reisenberger @YarekTyshchenko
Fix RateLimitRejectedException
ce36ab2
@reisenberger @YarekTyshchenko
Remove unused configuration overloads
9b74ae1
@reisenberger @YarekTyshchenko
Introduce a factory for obtaining the preferred rate-limiter implemen…
0e0d94f 
…tation
@reisenberger @YarekTyshchenko
Pull some test helper methods into a common base-class
3d83844
@reisenberger @YarekTyshchenko
Add first specs on async policy syntax
23f26e8
@reisenberger @YarekTyshchenko
Add full set of specs on rate-limit policies thus far
d0f191b
@reisenberger @YarekTyshchenko
Add tests on retryAfterFactory
705cda9
@reisenberger @YarekTyshchenko
Add tests on context passed to retryAfterFactory
68346c7
@reisenberger @YarekTyshchenko
Add async non-generic syntax and specs
1895edc
@reisenberger @YarekTyshchenko
Improve code layout
dd10d3e
@reisenberger @YarekTyshchenko
Add sync rate-limit policies
a734da2
@reisenberger @YarekTyshchenko
Add initial rate-limit doco; bump to v7.3.0
ba96aac
@reisenberger @YarekTyshchenko
Improve bulkhead doco in readme
f237d8f
@reisenberger @YarekTyshchenko
Minor expressivity refinements
b41cac4
@reisenberger @YarekTyshchenko
Neaten bulkhead tests commentary
1370cdb
@reisenberger @YarekTyshchenko
Control visibility of IRateLimiter components
b890f01
@reisenberger @YarekTyshchenko
Fix non-generic rate-limit tests to be genuinely non-generic
f232595
@YarekTyshchenko
Fix ShouldThrow syntax errors in specs
e566ea9
@derigel23
Copy link
Copy Markdown

derigel23 commented Dec 2, 2021

Any progress on accepting & merging this PR?

@martincostello
Copy link
Copy Markdown
Member

martincostello commented Dec 2, 2021 •
edited
Loading

I'm planning on reviving the other original PR imminently, but with some additional changes on top based on some minor tweaks we made in a private fork we've been running in production for the last 18 months.

@martincostello
Copy link
Copy Markdown
Member

martincostello commented Dec 2, 2021

Thank you for trying to resurrect #666 via this PR @YarekTyshchenko.

As this has been in draft for a while now I'm going to close this.

I've created a new PR with the aim to get the rate limiting policy merged here - #903.

Please address any comments on the functionality there.

@YarekTyshchenko YarekTyshchenko deleted the RateLimiter branch December 8, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@YarekTyshchenko @dnfadmin @derigel23 @martincostello @reisenberger