Upgrade FluentAssertions package

[dotnetspark]

The issue or feature being addressed

#913

Details on the issue fix or feature implementation

Upgrading FluentAssertions package to latest

Confirm the following

• I started this PR by branching from the head of the latest dev vX.Y branch, or I have rebased on the latest dev vX.Y branch, or I have merged the latest changes from the dev vX.Y branch
• I have targeted the PR to merge into the latest dev vX.Y branch as the base branch
• I have included unit tests for the issue/feature
• I have successfully run a local build

[dnfadmin]

All CLA requirements met.

[martincostello]

Thanks for picking this up @ylr-research!

Other than the one comment, these changes all look reasonable.

[martincostello]

The tests seem to be hanging somewhere.

[dotnetspark]

@martincostello, I just wrapped the kvp into a dictionary so it could compile on my end. I can't see the tests results.

[martincostello]

I would guess the problem is with one of the asynchronous tests you've changed, and the previous failure was masking it.

[dotnetspark]

I see 673 passed but it doesn't say which one failed

[martincostello]

I think that's the problem, it hasn't failed, it's still running and has hung.

[dotnetspark]

Do you think re-running could yield a different result? Otherwise, any suggestion on how to repro the one(s) hanging

[martincostello]

Not without going away and researching dotnet test parameters for helping to find such tests.

Presumably these all pass when you run them locally using the build script?

[dotnetspark]

I missed that. I was just compiling in VS.

[dotnetspark]

I missed that. I was just compiling in VS.

[dotnetspark]

I missed that. I was just compiling in VS. Let me check that

[dotnetspark]

I missed that. I was just building in VS. Let me try that

[dotnetspark]

@martincostello I found the issues. 30 tests not passing to be precise. All related to the same. Since I have changed Throw by ThrowAsync the expected result instead of 2 is now 1. Doing so let the test pass. Is this change correct?
Take test Should_wait_asynchronously_for_async_onretry_delegate for example, line 395 executeDelegateInvocations.Should().Be(1);

[martincostello]

Thanks for your contribution @ylr-research - I cloned the PR locally and took a look at the code.

The fundamental issue that was causing the deadlocks was that all the usages of Awaiting() needed to be awaited, so all the tests using it needed to be made async Task. I've gone through every single usage of the method and done the conversion, and now everything passes as expected.

[dotnetspark]

Great, thanks