lib/zlib: Bump minimum CMake version to 3.6

[trinitronx]

Fixing CMake version dependency related to: TheAssassin/AppImageLauncher#717

[TheAssassin]

Out of curiosity, why 3.6?

[trinitronx]

Out of curiosity, why 3.6?

The error message mentions that CMake < 3.5 compatibility has been deprecated:

  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

EDIT: Note that this was building with cmake version 4.0.2-1 from Arch Linux extra/cmake package.

[TheAssassin]

I'll have to fix the CI first.

[trinitronx]

FYI: It also seems that CMake version needs to be updated in at least a few more sub-dependencies:

• lib/zlib: Bump minimum CMake version to 3.6 #82
• args also needs CMake >= 3.6 - needs version bump here (changed in Taywee/args@114200a9ad5f)

[trinitronx]

Looks like it also needs one more update here ¹:

• AppImageCommunity/libappimage / CMakeLists.txt#L1

Footnotes

1. EDIT: Actually updates in a few more places, and probably this CMake min version needs to propagate to other sub-dependencies such as azubieta/xdg-utils-cxx. ↩

[TheAssassin]

Please don't hesitate to open more PRs, I'll happily merge all I can.

[TheAssassin]

Re. args, you can push an update to your branch as needed. For the record, < 3.5 means 3.5 is still supported (3.6 would be required if it was <= 3.5; < excludes the provided value).

[trinitronx]

Ok, pushed a few more PRs:

• Upstream: Bump minimum CMake version to 3.6 azubieta/xdg-utils-cxx#21
• Bump minimum CMake version to 3.6 libappimage#199

Once merged, we need to bump those GIT_TAG refs also to propagate the changes from sub-dependencies up:

• AppImageCommunity/libappimage / cmake/dependencies.cmake#L112
  • Already on master, so it's good once Bump minimum CMake version to 3.6 azubieta/xdg-utils-cxx#21 merges
  • Otherwise, we would need to bump it to pre-release version on a fork
• this repo: lib/CMakeLists.txt#L81 - Done in 53198ac
• AppImageCommunity/AppImageUpdate / CMakeLists.txt#L55
  • After this PR here merges, need to cut a release and bump to that new release tag
• AppImageCommunity/AppImageUpdate / CMakeLists.txt#L71
  • After Bump minimum CMake version to 3.6 libappimage#199 merges
  • Bump to either a new release or that ref sha (it's currently on a commit sha)
• TheAssassin/AppImageLauncher / CMakeLists.txt#L44
  • Once the above GIT_TAGs for dependencies are updated, bump the ref to pull in AppImageUpdate changes into the main AppImageLauncher CMake config

[trinitronx]

Re. args, you can push an update to your branch as needed.

Ok, pushed here in 53198ac

For the record, < 3.5 means 3.5 is still supported (3.6 would be required if it was <= 3.5; < excludes the provided value).

Makes sense. I must've misread it as <= earlier. I guess 3.6 gives us a bit more time if they decide to deprecate 3.5 at some point. Also it has more ninja ^{(features... that is 😅)}