Dockerfile: bump base image to Ubuntu 20.04 from 18.04#215
Merged
azubieta merged 1 commit intoAppImageCrafters:mainfrom Apr 14, 2022
ComunidadAylas:main
Merged
Dockerfile: bump base image to Ubuntu 20.04 from 18.04#215azubieta merged 1 commit intoAppImageCrafters:mainfrom ComunidadAylas:main
azubieta merged 1 commit intoAppImageCrafters:mainfrom
ComunidadAylas:main
Conversation
The latest appimage-builder alpha release at the time of writing, namely
v1.0.0-alpha.3, assumes that at least Python 3.8 is available. However,
Ubuntu 18.04 ships Python 3.6, and as such the Docker container errors
out at runtime when trying to import types that were added in Python
3.8:
```
Traceback (most recent call last):
File "/usr/local/bin/appimage-builder", line 11, in <module>
load_entry_point('appimage-builder==1.0.0a3', 'console_scripts', 'appimage-builder')()
File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 480, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2693, in load_entry_point
return ep.load()
File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2324, in load
return self.resolve()
File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2330, in resolve
module = __import__(self.module_name, fromlist=['__name__'], level=0)
File "/usr/local/lib/python3.6/dist-packages/appimage_builder-1.0.0a3-py3.6.egg/appimagebuilder/__main__.py", line 32, in <module>
from appimagebuilder.invoker import Invoker
File "/usr/local/lib/python3.6/dist-packages/appimage_builder-1.0.0a3-py3.6.egg/appimagebuilder/invoker.py", line 26, in <module>
from appimagebuilder.commands.command import Command
File "/usr/local/lib/python3.6/dist-packages/appimage_builder-1.0.0a3-py3.6.egg/appimagebuilder/commands/__init__.py", line 22, in <module>
from .setup_runtime import SetupRuntimeCommand
File "/usr/local/lib/python3.6/dist-packages/appimage_builder-1.0.0a3-py3.6.egg/appimagebuilder/commands/setup_runtime.py", line 12, in <module>
from appimagebuilder.modules.setup.generator import RuntimeGenerator
File "/usr/local/lib/python3.6/dist-packages/appimage_builder-1.0.0a3-py3.6.egg/appimagebuilder/modules/setup/generator.py", line 18, in <module>
from typing import Final
ImportError: cannot import name 'Final'
```
Update the base image to something more modern, Ubuntu 20.04, to fix
this issue. Setting the DEBIAN_FRONTEND and -yq parameter to apt-get was
necessary to avoid `docker build` interactively prompting for timezone
data configuration parameters, due to the `tzdata` Ubuntu package.
Contributor
|
Good catch! Thanks a lot for the contribution!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest appimage-builder alpha release at the time of writing, v1.0.0-alpha.3, assumes that at least Python 3.8 is available. However, Ubuntu 18.04 ships Python 3.6, and as such the Docker container errors out at runtime when trying to import types that were added in Python 3.8:
Update the base image to something more modern, Ubuntu 20.04, to fix this issue. Setting the DEBIAN_FRONTEND and -yq parameter to apt-get was necessary to avoid
docker buildinteractively prompting for timezone data configuration parameters, due to thetzdataUbuntu package.