make timeout override to be partial and enable enable check exclusion.#79
make timeout override to be partial and enable enable check exclusion.#79saikrishna321 merged 9 commits intomainfrom
Conversation
|
@saikrishna321 review and release. |
|
@Dileep17 please update package-lock |
src/element.js
Outdated
| newtimeouts.intervalBetweenAttempts = elementWaitProps.intervalBetweenAttempts; | ||
| } | ||
| if (elementWaitProps.excludeEnabledCheck) { | ||
| newtimeouts.excludeEnabledCheck = elementWaitProps.excludeEnabledCheck; |
There was a problem hiding this comment.
Can we use object assignment here instead of multiple if statements?
Something like:
const newTimeouts = {
timeout: elementWaitProps.timeout || defaultTimeOuts.timeout,
intervalBetweenAttempts: elementWaitProps.intervalBetweenAttempts || defaultTimeOuts.intervalBetweenAttempts,
excludeEnabledCheck: elementWaitProps.excludeEnabledCheck || defaultTimeOuts.excludeEnabledCheck
};
There was a problem hiding this comment.
@SrinivasanTarget @saikrishna321 refactored to reduce the complexity of assigning defaults and overrides.
|
🏷️ [bumpr] Next version:2.0.0 Changes:1.5.0...AppiumTestDistribution:feature/#78 |
|
🚀 [bumpr] Bumped! New version:2.0.0 Changes:1.5.0...2.0.0 |
3 participants
fix #78