Skip to content

fix(docker): actually install certificates from CUSTOM_CERT_DIR #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lbarrosby wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(docker): actually install certificates from CUSTOM_CERT_DIR #623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,19 @@ RUN apt-get update && apt-get install -y \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*

# Update certificates if custom ones were provided and copied successfully
RUN if [ -n "${CUSTOM_CERT_DIR}" ]; then \
mkdir -p /usr/local/share/ca-certificates && \
if [ -d "${CUSTOM_CERT_DIR}" ]; then \
cp -r ${CUSTOM_CERT_DIR}/* /usr/local/share/ca-certificates/ 2>/dev/null || true; \
update-ca-certificates; \
echo "Custom certificates installed successfully."; \
else \
echo "Warning: ${CUSTOM_CERT_DIR} not found. Skipping certificate installation."; \
fi \
# Install custom CA certificates (.crt or .pem) from CUSTOM_CERT_DIR in the build context, if present
ARG CUSTOM_CERT_DIR
RUN --mount=type=bind,target=/tmp/build-context \
CERT_SRC="/tmp/build-context/${CUSTOM_CERT_DIR}"; \
if [ -n "${CUSTOM_CERT_DIR}" ] && [ -d "${CERT_SRC}" ]; then \
mkdir -p /usr/local/share/ca-certificates/custom && \
find "${CERT_SRC}" -type f \( -name '*.crt' -o -name '*.pem' \) | while read -r cert; do \
name=$(basename "${cert}"); \
cp "${cert}" "/usr/local/share/ca-certificates/custom/${name%.*}.crt"; \
done && \
update-ca-certificates; \
else \
echo "No custom certificates found in '${CUSTOM_CERT_DIR}', skipping."; \
fi

ENV PATH="/opt/venv/bin:$PATH"
Expand Down
Loading