Skip to content

refactor: deduplicate Fzf index construction in useThreads - #2

Merged
Vect0rM merged 1 commit into
AtomicBot-ai:mainfrom
Angelopgit:refactor/use-threads-search-index-dedup
Apr 24, 2026
Merged

Vect0rM merged 1 commit into
AtomicBot-ai:mainfrom
Angelopgit:refactor/use-threads-search-index-dedup

Conversation

@Angelopgit

Copy link
Copy Markdown
Contributor

The useThreads store was constructing new Fzf(...) inline in seven separate mutation actions (setThreads, deleteThread, deleteAllThreads, clearAllThreads, deleteAllThreadsByProject, renameThread, updateThreadTimestamp, updateThread), each with an identical filter predicate and selector. The construction logic was copied verbatim each time, which meant any future change to index behavior (different selector, additional filters, etc.) would need to be applied in seven places.

This PR extracts a buildSearchIndex helper at the module level and replaces all seven inline constructions with a call to it. The change is purely mechanical — no behavior is altered.

While in deleteAllThreadsByProject, the deletion-id lookup was using Array.prototype.includes inside a .filter, giving O(n·k) behavior when k ids are being deleted from n total threads. Changed to a Set so the .has check is O(1).

Tested: logic is unchanged and exercised by any interaction that creates, deletes, renames, or updates a thread. No new runtime paths introduced.

Extracts a buildSearchIndex helper to replace seven identical
new Fzf(...) expressions scattered across mutation actions. Also
changes deleteAllThreadsByProject to use a Set for the deletion
lookup so the subsequent .filter check is O(1) instead of O(n).
No behavioral changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants