Repository navigation
Conversation
Extracts a buildSearchIndex helper to replace seven identical new Fzf(...) expressions scattered across mutation actions. Also changes deleteAllThreadsByProject to use a Set for the deletion lookup so the subsequent .filter check is O(1) instead of O(n). No behavioral changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
useThreadsstore was constructingnew Fzf(...)inline in seven separate mutation actions (setThreads,deleteThread,deleteAllThreads,clearAllThreads,deleteAllThreadsByProject,renameThread,updateThreadTimestamp,updateThread), each with an identical filter predicate and selector. The construction logic was copied verbatim each time, which meant any future change to index behavior (different selector, additional filters, etc.) would need to be applied in seven places.This PR extracts a
buildSearchIndexhelper at the module level and replaces all seven inline constructions with a call to it. The change is purely mechanical — no behavior is altered.While in
deleteAllThreadsByProject, the deletion-id lookup was usingArray.prototype.includesinside a.filter, giving O(n·k) behavior when k ids are being deleted from n total threads. Changed to aSetso the.hascheck is O(1).Tested: logic is unchanged and exercised by any interaction that creates, deletes, renames, or updates a thread. No new runtime paths introduced.