Repository navigation
feat(desktop): @file menu in the composer and collapsed file block in chat (ATO-1596, ATO-1597) - #1619
Draft
sosidudku1 wants to merge 2 commits into
Draft
feat(desktop): @file menu in the composer and collapsed file block in chat (ATO-1596, ATO-1597)#1619sosidudku1 wants to merge 2 commits into
sosidudku1 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ATO-1496 (desktop
@file mentions). This PR is the renderer half: ATO-1596 and ATO-1597. It needs the main/preload half, #1614 (window.atomic.mentionsSearchand the<mentioned-files>block on send). Without it the menu simply never opens.Behaviour copied from our TUI (PR #1428) and Claude Code / Cursor
@file.ATO-1596: the @ menu in the composer
desktop/renderer/file-mentions.jsholds all the logic.@at the start of a line or after whitespace opens the menu;me@site.comdoes not. Text that starts with/keeps the slash menu.mentionsSearch(skillSessionId(), query)(the same session idskillListuses); a stale answer is dropped. Up to 50 rows; an empty result shows "No matching files".@path(with one trailing space), Esc closes. While the menu is open Enter never sends. IME composition is ignored (isComposing/ 229). Click on a row inserts too.renderer.js: four one-line hooks next to the slash menu (popover, click, input, keydown). Styles reuse.slashlist,.slashrow,.slashfootplus.fmmenuand.fmrowincomposer.css.ATO-1597: the block in the chat history
<mentioned-files>block shows one line per file under the bubble (@src/app.ts · 4 KB, plus "truncated" when cut), not the file contents.attachments.js:attSplitMessagestrips the mention block first;attToEditor,attPlainTextandattQueueLabeldrop it, so "send again", rollback, copy and the queue label use only the typed text and files are not inlined twice.renderer.js: the two caption comparisons in resend/regenerate useattPlainText.Tests
desktop/test/file-mentions-renderer.test.mjs: query detection (start, after space, not inside an email), path insertion and caret, block parse and one-line summaries, block stripped for editing.Not yet checked on the second Mac.