Repository navigation
fix(desktop): local-as-last-resort reads Off when unset, like the agent (ATO-1643) - #1701
Draft
sosidudku1 wants to merge 2 commits into
Draft
sosidudku1 wants to merge 2 commits into
sosidudku1 wants to merge 2 commits into
Conversation
… value (ATO-1643) Since v0.7.0 the agent leaves the local model out of the fallback chain unless llm.fallback.appendLocal is true. The desktop read an unset value as on, so Settings > Fallback showed On with the local model in the chain and the turn gate promised a fallback the agent never runs. Both places now treat unset as off, like DEFAULT_APPEND_LOCAL.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Settings > Fallback showed "Use local models as the last resort: On" and drew the local model at the end of the chain when
llm.fallback.appendLocalwas not written in the config. The agent does the opposite: since v0.7.0 it only appends the local model when the value istrue(DEFAULT_APPEND_LOCAL = falseinsrc/llm/fallback/fallback-config.ts). The turn gate had the same old default, so its "running this turn through the fallback chain" notice could promise a local fallback that never runs.Now both places in
desktop/renderer/renderer.jsread an unset value as off:llmFallbackView():appendLocal = fb.appendLocal === truelocalTurnGate(): appends the local model only whenfb.appendLocal === trueThe toggle already writes the flipped view value, so turning it on from Off writes
trueas before.Why
The screen should show what the agent actually does.
Tests
New
desktop/test/fallback-append-local-default.test.mjs: no fallback block, a block without the key,trueandfalse, plus a check that the turn gate no longer uses the unset-means-on test.Verification
npm run test:unitindesktop/(the new file).llm.fallbackfrom~/.atomic-agent/config.json, open Settings > Fallback: the switch reads Off and no local model sits in the chain. Turn it on: the config getsappendLocal: trueand the local model appears last.Not yet checked on the second Mac.