Repository navigation
fix(fusion): recheck all acceptance lists after judge repair - #1734
Open
metallbaubehrmann-dev wants to merge 1 commit into
Open
metallbaubehrmann-dev wants to merge 1 commit into
metallbaubehrmann-dev wants to merge 1 commit into
Conversation
A repaired task can invalidate a different task's previously passing checks or judged evidence. Rebuild acceptance results from worker outcomes and rejudge the full current fan-out after the existing bounded retry. Cover cross-task regression through real verify.run commands, fresh model evidence, correct repairs and an unavailable post-repair check runner. Refs AtomicBot-ai#539 Follow-up to AtomicBot-ai#605
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A judge retry can fix task B while breaking task A, which already passed. Fusion reruns all contract checks, but currently applies the new results and judge verdicts only to the retried tasks. A can therefore remain
okwithchecks.failed: 0andjudge.green: trueeven when the final contract report says its check failed. If the second check run is unavailable, A can also retain its stale pass.Change
This is a focused follow-up to #605 on current main, using the native opt-in judge introduced since that PR:
The worker retry count remains one, judge-off behavior is unchanged, and the additional judge calls use the existing turn budget. No new config flag, worker-runner interface, default policy, or global terminal gate is introduced. This does not port the old 28-file implementation or claim to finish all of #539.
Verification
Linux, Node 25.7.0 (matching the repository/CI version), lockfile install, base
6d1f14fcd4ae08e592a71fe52f0146c5aa7bab64.verify.run: first[A: pass, B: fail], then[A: fail, B: pass]. Other cases check fresh model evidence, acceptance of a correct repair, and a failed post-repair check runner. Model completions in tests are deterministic doubles, not a model-quality benchmark.Test scopes overlap and are not additive. GitHub CI and maintainer acceptance are separate from these local checks.
Refs #539, especially the requirement to recheck the whole list after every repair.
Follow-up to #605 and the invitation to submit a focused change against current main.