Repository navigation
perf(catalog): compute filters and facets in one pass - #111
Merged
Merged
Conversation
独立した5走査との比較でmood・tag選択と複数軸の不一致を確認する。計測を行わない検査名を整え、既存の実行経路を維持する。
mashfromband
marked this pull request as ready for review
November 15, 2026 02:21
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: b6e1eb3f-3144-4135-bc0b-d4434eaab6bc) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


カタログの絞り込み結果と4軸ファセットの件数を別々に走査していたため、検索や選択変更で同じ判定を繰り返していました。各セルの軸一致と検索判定から結果と件数を一度に計算し、候補値、結果順、重複タグの数え方、日英検索、既存の表示を保持します。
実ソースを読み込む9つの回帰テストで、軸内OR・軸間AND、自軸を除いた件数、mood・tag選択、複数軸の不一致、同数時の並び順、moodだけの破損を確認しました。有限の3,072選択を、期待値を別に求める5走査の実装とも比較します。同じheadのCIで9件成功・除外0、型・データ・a11y検査、静的ビルド、機密検出とCodeQLが成功しました。これらは返却値の検査で、処理時間の計測やReact画面の描画検査ではありません。
51,729件のDOM描画と初回表示の遅延は継続課題です。この変更の計算改善だけで表示性能全体の改善済みとは扱いません。
Closes #110.
Related: #21.