Skip to content

perf(catalog): compute filters and facets in one pass - #111

Merged
mashfromband merged 2 commits into
mainfrom
codex/catalog-projection
Nov 15, 2026
Merged

mashfromband merged 2 commits into
mainfrom
codex/catalog-projection

Conversation

@mashfromband

@mashfromband mashfromband commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

カタログの絞り込み結果と4軸ファセットの件数を別々に走査していたため、検索や選択変更で同じ判定を繰り返していました。各セルの軸一致と検索判定から結果と件数を一度に計算し、候補値、結果順、重複タグの数え方、日英検索、既存の表示を保持します。

実ソースを読み込む9つの回帰テストで、軸内OR・軸間AND、自軸を除いた件数、mood・tag選択、複数軸の不一致、同数時の並び順、moodだけの破損を確認しました。有限の3,072選択を、期待値を別に求める5走査の実装とも比較します。同じheadのCIで9件成功・除外0、型・データ・a11y検査、静的ビルド、機密検出とCodeQLが成功しました。これらは返却値の検査で、処理時間の計測やReact画面の描画検査ではありません。

51,729件のDOM描画と初回表示の遅延は継続課題です。この変更の計算改善だけで表示性能全体の改善済みとは扱いません。

Closes #110.
Related: #21.

独立した5走査との比較でmood・tag選択と複数軸の不一致を確認する。計測を行わない検査名を整え、既存の実行経路を維持する。
@mashfromband
mashfromband marked this pull request as ready for review November 15, 2026 02:21
@cursor

cursor Bot commented Nov 15, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: b6e1eb3f-3144-4135-bc0b-d4434eaab6bc)

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Cursor Bugbot was skipped after hitting a usage limit, so that signal was omitted; remaining checks passed and no unresolved review findings require human attention. No reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@mashfromband
mashfromband merged commit 320a882 into main Nov 15, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

カタログ検索とファセット件数の重複走査を減らす

1 participant